Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(instr-openai): refactor some test envvars and the Q used for testing chat completion #497

Merged
merged 3 commits into from
Dec 26, 2024
Merged

test(instr-openai): refactor some test envvars and the Q used for testing chat completion #497

merged 3 commits into from
Dec 26, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Dec 19, 2024

No description provided.

@trentm trentm self-assigned this Dec 19, 2024
@trentm trentm changed the title test(instr-openai): refactor test envvar names test(instr-openai): refactor some test envvars and the Q used for testing chat completion Dec 19, 2024
@trentm trentm marked this pull request as ready for review December 19, 2024 19:22
codefromthecrypt
codefromthecrypt approved these changes Dec 20, 2024
View reviewed changes
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codefromthecrypt codefromthecrypt merged commit 731abfe into main Dec 26, 2024
7 checks passed
@codefromthecrypt codefromthecrypt deleted the trentm/instr-openai-test-tweaks branch December 26, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trentm @codefromthecrypt @david-luna